cloud-init

cc_resizefs for zfs/zpool

Bug #1721243 reported by do3meli on 2017-10-04

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	cloud-init	Fix Released	Medium	do3meli

Bug Description

the resizefs module is not able to handle zfs/zpool resizing for the root filesystem. if tried so we get the error message: "Could not determine filesystem type of /".

version: cloud_init-17.1-py2.7.egg

Tags:

Related branches

~chad.smith/cloud-init:ubuntu/artful

Merged into cloud-init:ubuntu/artful at revision 903f02e16735bfa0c745330c1be63363c0798fcf

Server Team CI bot: Approve (continuous-integration) on 2018-03-28

Scott Moser: Pending requested 2018-03-27

Diff: 7933 lines (+4629/-634)

103 files modified

.pylintrc (+11/-1)
ChangeLog (+110/-0)
cloudinit/apport.py (+3/-3)
cloudinit/cloud.py (+3/-2)
cloudinit/cmd/main.py (+29/-6)
cloudinit/cmd/tests/test_clean.py (+2/-1)
cloudinit/cmd/tests/test_main.py (+161/-0)
cloudinit/cmd/tests/test_status.py (+2/-1)
cloudinit/config/cc_keys_to_console.py (+1/-3)
cloudinit/config/cc_puppet.py (+44/-15)
cloudinit/config/cc_resizefs.py (+22/-0)
cloudinit/config/cc_runcmd.py (+4/-2)
cloudinit/config/cc_salt_minion.py (+65/-20)
cloudinit/config/cc_set_hostname.py (+35/-6)
cloudinit/config/cc_snap.py (+230/-0)
cloudinit/config/cc_snap_config.py (+7/-0)
cloudinit/config/cc_snappy.py (+8/-0)
cloudinit/config/cc_ssh_authkey_fingerprints.py (+4/-5)
cloudinit/config/cc_ubuntu_advantage.py (+173/-0)
cloudinit/config/tests/test_snap.py (+490/-0)
cloudinit/config/tests/test_ubuntu_advantage.py (+269/-0)
cloudinit/distros/arch.py (+1/-4)
cloudinit/distros/freebsd.py (+6/-0)
cloudinit/distros/opensuse.py (+2/-3)
cloudinit/ec2_utils.py (+2/-4)
cloudinit/net/cmdline.py (+22/-2)
cloudinit/net/netplan.py (+14/-21)
cloudinit/net/network_state.py (+11/-1)
cloudinit/settings.py (+2/-0)
cloudinit/sources/DataSourceAliYun.py (+1/-1)
cloudinit/sources/DataSourceAzure.py (+11/-22)
cloudinit/sources/DataSourceCloudSigma.py (+1/-1)
cloudinit/sources/DataSourceConfigDrive.py (+10/-0)
cloudinit/sources/DataSourceGCE.py (+8/-9)
cloudinit/sources/DataSourceHetzner.py (+106/-0)
cloudinit/sources/DataSourceIBMCloud.py (+325/-0)
cloudinit/sources/DataSourceOVF.py (+16/-5)
cloudinit/sources/DataSourceOpenNebula.py (+75/-34)
cloudinit/sources/DataSourceScaleway.py (+4/-4)
cloudinit/sources/__init__.py (+17/-4)
cloudinit/sources/helpers/hetzner.py (+26/-0)
cloudinit/sources/tests/test_init.py (+97/-1)
cloudinit/stages.py (+1/-2)
cloudinit/subp.py (+57/-0)
cloudinit/tests/helpers.py (+35/-19)
cloudinit/tests/test_subp.py (+61/-0)
cloudinit/tests/test_util.py (+169/-0)
cloudinit/url_helper.py (+14/-10)
cloudinit/util.py (+115/-24)
cloudinit/version.py (+1/-1)
config/cloud.cfg.tmpl (+9/-3)
debian/changelog (+69/-3)
doc/examples/cloud-config-chef.txt (+2/-2)
doc/rtd/conf.py (+1/-0)
doc/rtd/topics/capabilities.rst (+8/-6)
doc/rtd/topics/debugging.rst (+31/-26)
doc/rtd/topics/modules.rst (+2/-0)
doc/rtd/topics/network-config.rst (+2/-2)
doc/rtd/topics/tests.rst (+10/-10)
packages/debian/control.in (+2/-1)
tests/cloud_tests/bddeb.py (+1/-1)
tests/cloud_tests/platforms/ec2/__init__.py (+0/-0)
tests/cloud_tests/platforms/lxd/__init__.py (+0/-0)
tests/cloud_tests/platforms/lxd/platform.py (+0/-4)
tests/cloud_tests/platforms/nocloudkvm/__init__.py (+0/-0)
tests/cloud_tests/platforms/nocloudkvm/instance.py (+1/-1)
tests/cloud_tests/platforms/nocloudkvm/platform.py (+0/-4)
tests/cloud_tests/platforms/platforms.py (+12/-2)
tests/cloud_tests/releases.yaml (+3/-0)
tests/cloud_tests/testcases.yaml (+3/-0)
tests/cloud_tests/testcases/__init__.py (+3/-0)
tests/cloud_tests/testcases/base.py (+168/-5)
tests/cloud_tests/testcases/main/command_output_simple.py (+2/-15)
tests/cloud_tests/testcases/modules/salt_minion.py (+10/-0)
tests/cloud_tests/testcases/modules/salt_minion.yaml (+9/-1)
tests/cloud_tests/testcases/modules/snap.py (+16/-0)
tests/cloud_tests/testcases/modules/snap.yaml (+18/-0)
tests/cloud_tests/testcases/modules/snappy.py (+2/-0)
tests/cloud_tests/util.py (+5/-1)
tests/cloud_tests/verify.py (+7/-4)
tests/data/mount_parse_ext.txt (+19/-0)
tests/data/mount_parse_zfs.txt (+21/-0)
tests/data/zpool_status_simple.txt (+10/-0)
tests/unittests/test_datasource/test_azure.py (+22/-15)
tests/unittests/test_datasource/test_common.py (+4/-0)
tests/unittests/test_datasource/test_gce.py (+19/-1)
tests/unittests/test_datasource/test_hetzner.py (+117/-0)
tests/unittests/test_datasource/test_ibmcloud.py (+262/-0)
tests/unittests/test_datasource/test_opennebula.py (+177/-89)
tests/unittests/test_ds_identify.py (+161/-6)
tests/unittests/test_handler/test_handler_apt_source_v1.py (+2/-1)
tests/unittests/test_handler/test_handler_bootcmd.py (+7/-12)
tests/unittests/test_handler/test_handler_ntp.py (+6/-12)
tests/unittests/test_handler/test_handler_resizefs.py (+60/-12)
tests/unittests/test_handler/test_handler_runcmd.py (+4/-10)
tests/unittests/test_handler/test_handler_set_hostname.py (+53/-4)
tests/unittests/test_handler/test_schema.py (+16/-19)
tests/unittests/test_net.py (+58/-81)
tests/unittests/test_util.py (+135/-0)
tools/ds-identify (+99/-28)
tools/pipremove (+14/-0)
tools/run-centos (+78/-13)
tox.ini (+6/-3)

~chad.smith/cloud-init:ubuntu/xenial

Merged into cloud-init:ubuntu/xenial at revision e9ebc06ea8d64e5a50fa17995a639527115bc544

Server Team CI bot: Approve (continuous-integration) on 2018-03-28

Scott Moser: Pending requested 2018-03-27

Diff: 7954 lines (+4621/-638)

105 files modified

.pylintrc (+11/-1)
ChangeLog (+110/-0)
cloudinit/apport.py (+3/-3)
cloudinit/cloud.py (+3/-2)
cloudinit/cmd/main.py (+29/-6)
cloudinit/cmd/tests/test_clean.py (+2/-1)
cloudinit/cmd/tests/test_main.py (+161/-0)
cloudinit/cmd/tests/test_status.py (+2/-1)
cloudinit/config/cc_keys_to_console.py (+1/-3)
cloudinit/config/cc_puppet.py (+44/-15)
cloudinit/config/cc_resizefs.py (+22/-0)
cloudinit/config/cc_runcmd.py (+4/-2)
cloudinit/config/cc_salt_minion.py (+65/-20)
cloudinit/config/cc_set_hostname.py (+35/-6)
cloudinit/config/cc_snap.py (+230/-0)
cloudinit/config/cc_snap_config.py (+7/-0)
cloudinit/config/cc_snappy.py (+8/-0)
cloudinit/config/cc_ssh_authkey_fingerprints.py (+4/-5)
cloudinit/config/cc_ubuntu_advantage.py (+173/-0)
cloudinit/config/tests/test_snap.py (+490/-0)
cloudinit/config/tests/test_ubuntu_advantage.py (+269/-0)
cloudinit/distros/arch.py (+1/-4)
cloudinit/distros/freebsd.py (+6/-0)
cloudinit/distros/opensuse.py (+2/-3)
cloudinit/ec2_utils.py (+2/-4)
cloudinit/net/cmdline.py (+22/-2)
cloudinit/net/netplan.py (+14/-21)
cloudinit/net/network_state.py (+11/-1)
cloudinit/settings.py (+2/-0)
cloudinit/sources/DataSourceAliYun.py (+1/-1)
cloudinit/sources/DataSourceAzure.py (+11/-22)
cloudinit/sources/DataSourceCloudSigma.py (+1/-1)
cloudinit/sources/DataSourceConfigDrive.py (+10/-0)
cloudinit/sources/DataSourceGCE.py (+8/-9)
cloudinit/sources/DataSourceHetzner.py (+106/-0)
cloudinit/sources/DataSourceIBMCloud.py (+325/-0)
cloudinit/sources/DataSourceOVF.py (+16/-5)
cloudinit/sources/DataSourceOpenNebula.py (+75/-34)
cloudinit/sources/DataSourceScaleway.py (+4/-4)
cloudinit/sources/__init__.py (+17/-4)
cloudinit/sources/helpers/hetzner.py (+26/-0)
cloudinit/sources/tests/test_init.py (+97/-1)
cloudinit/stages.py (+1/-2)
cloudinit/subp.py (+57/-0)
cloudinit/tests/helpers.py (+35/-19)
cloudinit/tests/test_subp.py (+61/-0)
cloudinit/tests/test_util.py (+169/-0)
cloudinit/url_helper.py (+14/-10)
cloudinit/util.py (+115/-24)
cloudinit/version.py (+1/-1)
config/cloud.cfg.tmpl (+9/-3)
debian/changelog (+57/-3)
debian/patches/azure-use-walinux-agent.patch (+1/-1)
debian/patches/ds-identify-behavior-xenial.patch (+3/-3)
doc/examples/cloud-config-chef.txt (+2/-2)
doc/rtd/conf.py (+1/-0)
doc/rtd/topics/capabilities.rst (+8/-6)
doc/rtd/topics/debugging.rst (+31/-26)
doc/rtd/topics/modules.rst (+2/-0)
doc/rtd/topics/network-config.rst (+2/-2)
doc/rtd/topics/tests.rst (+10/-10)
packages/debian/control.in (+2/-1)
tests/cloud_tests/bddeb.py (+1/-1)
tests/cloud_tests/platforms/ec2/__init__.py (+0/-0)
tests/cloud_tests/platforms/lxd/__init__.py (+0/-0)
tests/cloud_tests/platforms/lxd/platform.py (+0/-4)
tests/cloud_tests/platforms/nocloudkvm/__init__.py (+0/-0)
tests/cloud_tests/platforms/nocloudkvm/instance.py (+1/-1)
tests/cloud_tests/platforms/nocloudkvm/platform.py (+0/-4)
tests/cloud_tests/platforms/platforms.py (+12/-2)
tests/cloud_tests/releases.yaml (+3/-0)
tests/cloud_tests/testcases.yaml (+3/-0)
tests/cloud_tests/testcases/__init__.py (+3/-0)
tests/cloud_tests/testcases/base.py (+168/-5)
tests/cloud_tests/testcases/main/command_output_simple.py (+2/-15)
tests/cloud_tests/testcases/modules/salt_minion.py (+10/-0)
tests/cloud_tests/testcases/modules/salt_minion.yaml (+9/-1)
tests/cloud_tests/testcases/modules/snap.py (+16/-0)
tests/cloud_tests/testcases/modules/snap.yaml (+18/-0)
tests/cloud_tests/testcases/modules/snappy.py (+2/-0)
tests/cloud_tests/util.py (+5/-1)
tests/cloud_tests/verify.py (+7/-4)
tests/data/mount_parse_ext.txt (+19/-0)
tests/data/mount_parse_zfs.txt (+21/-0)
tests/data/zpool_status_simple.txt (+10/-0)
tests/unittests/test_datasource/test_azure.py (+22/-15)
tests/unittests/test_datasource/test_common.py (+4/-0)
tests/unittests/test_datasource/test_gce.py (+19/-1)
tests/unittests/test_datasource/test_hetzner.py (+117/-0)
tests/unittests/test_datasource/test_ibmcloud.py (+262/-0)
tests/unittests/test_datasource/test_opennebula.py (+177/-89)
tests/unittests/test_ds_identify.py (+161/-6)
tests/unittests/test_handler/test_handler_apt_source_v1.py (+2/-1)
tests/unittests/test_handler/test_handler_bootcmd.py (+7/-12)
tests/unittests/test_handler/test_handler_ntp.py (+6/-12)
tests/unittests/test_handler/test_handler_resizefs.py (+60/-12)
tests/unittests/test_handler/test_handler_runcmd.py (+4/-10)
tests/unittests/test_handler/test_handler_set_hostname.py (+53/-4)
tests/unittests/test_handler/test_schema.py (+16/-19)
tests/unittests/test_net.py (+58/-81)
tests/unittests/test_util.py (+135/-0)
tools/ds-identify (+99/-28)
tools/pipremove (+14/-0)
tools/run-centos (+78/-13)
tox.ini (+6/-3)

~chad.smith/cloud-init:ubuntu/devel

Merged into cloud-init:ubuntu/devel at revision 10ab9a7c231b6f7d01da3a3a4c08cf4db01f5a87

Server Team CI bot: Approve (continuous-integration) on 2018-03-27

Scott Moser: Pending requested 2018-03-27

~d-info-e/cloud-init:resizefs-on-zfs-root

Merged into cloud-init:master at revision 20e3ddab7f55c2bf5e700c69fd24a0ac2206dbcf

Scott Moser: Approve on 2018-03-27

Server Team CI bot: Approve (continuous-integration) on 2018-03-27

Revision history for this message

Joshua Powers (powersj) wrote on 2017-10-04:

Hi! Thanks for taking the time to file a bug report.

Would it be possible to at least get both cloud-init logs from /var/log/cloud-init*?

I will move this to incomplete and when you attach them, please move the bug back to new. Thanks!

Changed in cloud-init:
status:	New → Incomplete
importance:	Undecided → Medium

Revision history for this message

do3meli (d-info-e) wrote on 2017-10-05:

cloud-init.log Edit (925 bytes, text/plain)

Revision history for this message

do3meli (d-info-e) wrote on 2017-10-05:

cloud-init-output.log Edit (190 bytes, text/plain)

Changed in cloud-init:
status:	Incomplete → New

Revision history for this message

do3meli (d-info-e) wrote on 2017-10-05:

cloud-init-root-on-zfs-resize.patch Edit (4.0 KiB, text/plain)

i have created a patch that works for me so far. please have a look at it. any feedback is welcome. i hope this is a good base for a merge.

also note that this bug may be related to https://bugs.launchpad.net/cloud-init/+bug/1645947

Revision history for this message

Scott Moser (smoser) wrote on 2017-10-05:

Hello do3meli,

Thank you for your contribution to cloud-init. Contributions to
cloud-init require the developer to have signed the Canonical Contributors
Agreement [1]. Your launchpad id is not currently listed as a member of
the contributor-agreement-canonical group [2].

Membership in that group is currently managed by a manual process, so it
is possible that you have followed the process but were not added to the
group. If you have already signed the contributor agreement, please
simply say so here.

For more information on contribution see the hacking documentation in
cloud-init [3].

If you have any questions, feel free to reach out in IRC (#cloud-init or private message) or via email.

Thanks again,
--
[1] https://www.ubuntu.com/legal/contributors
[2] https://launchpad.net/~contributor-agreement-canonical/+members
[3] http://cloudinit.readthedocs.io/en/latest/topics/hacking.html

Revision history for this message

do3meli (d-info-e) wrote on 2018-02-28:

Hi Scott,
I have just now signed the contributor agreement. may you have a look at it and grant me membership so we can go ahead and start looking at a possible merge?
thanks & regards
dom

Revision history for this message

Scott Moser (smoser) wrote on 2018-02-28:

do3meli,
Hi.
Thanks for following up.
Take a look at the hacking.html doc link listed above, and submit a merge proposal and we'll get it.

A quick look, my first comment is that unit tests on your added code would be great.

But please submit a merge proposal and we'll have the C-I bot run on your branch.

Let me know if you have any questions.
Thanks,
Scott

do3meli (d-info-e) on 2018-03-01

Changed in cloud-init:
status:	New → In Progress

do3meli (d-info-e) on 2018-03-06

Changed in cloud-init:
assignee:	nobody → do3meli (d-info-e)

do3meli (d-info-e) on 2018-03-17

tags:	added: zfs
tags:	added: freebsd

Revision history for this message

Scott Moser (smoser) wrote on 2018-03-27:

An upstream commit landed for this bug.

To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=20e3ddab

Changed in cloud-init:
status:	In Progress → Fix Committed

Revision history for this message

Chad Smith (chad.smith) wrote on 2018-03-27: Fixed in Cloud-init 18.2

This bug is believed to be fixed in cloud-init in 18.2. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in cloud-init:
status:	Fix Committed → Fix Released

Revision history for this message

James Falcon (falcojr) wrote on 2023-05-11:

#10

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3019

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1645947

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

cloud-init-root-on-zfs-resize.patch Edit

Add patch

Bug attachments

Add attachment

Remote bug watches

auto-github-canonical-cloud-init #3019
[closed launchpad] Edit

Bug watches keep track of this bug in other bug trackers.