logrotate never recovers if the statefile is corrupted

Using the above reproducer ^ ....

I confirm that logrotate never recover if the statefile is corrupted unless you remove it or fix the corruption by hand.

The upstream fix introduce in 3.12.0-18 [1] is fixing the issue[2] (tested using Artful so far)

Since all supported|devel releases are lower than 3.12 [3], then all releases are affected.

[1] - https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a

# git describe --contains b9d8200
3.12.0~18

[2] - https://github.com/logrotate/logrotate/issues/45

[3] - rmadison
logrotate | 3.8.7-1ubuntu1 | trusty | source, amd64, arm64, armhf, i386, powerpc, ppc64el
logrotate | 3.8.7-1ubuntu1 | vivid | source, amd64, arm64, armhf, i386, powerpc, ppc64el
logrotate | 3.8.7-1ubuntu1.1 | trusty-updates | source, amd64, arm64, armhf, i386, powerpc, ppc64el
logrotate | 3.8.7-2ubuntu2 | xenial | source, amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
logrotate | 3.8.7-2ubuntu2.16.04.1 | xenial-updates | source, amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
logrotate | 3.8.7-2ubuntu3 | zesty | source, amd64, arm64, armhf, i386, ppc64el, s390x
logrotate | 3.8.7-2ubuntu3 | artful | source, amd64, arm64, armhf, i386, ppc64el, s390x

Regards,
Eric

Debdiff for devel release Artful.

Sponsored to artful.

Tested the patch package (pre-SRU) on trusty and it works as expected.

This bug was fixed in the package logrotate - 3.8.7-2ubuntu4

---------------
logrotate (3.8.7-2ubuntu4) artful; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
    - d/p/do-not-treat-failure-of-readState-as-fatal.patch
    (Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers <email address hidden> Wed, 09 Aug 2017 11:39:36 -0700

Debdiff for stable release : Trusty/14.04 LTS lp1709670-logrotate-trusty.debdiff

Debdiff for stable release : Zesty/17.04

Debdiff for stable release : Xenial/16.04 LTS

Trusty, Xenial & Zesty has been sponsored by myself in their respective upload queues.

Now waiting for the SRU verification team approval for the package to start building in $RELEASE-proposed for the testing phase.

- Eric

Hello Ramon, or anyone else affected,

Accepted logrotate into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/logrotate/3.8.7-2ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Ramon, or anyone else affected,

Accepted logrotate into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/logrotate/3.8.7-2ubuntu2.16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Ramon, or anyone else affected,

Accepted logrotate into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/logrotate/3.8.7-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

### VERIFICATION XENIAL ###

* Couldn't reproduce the above situation using the proposed package version "3.8.7-2ubuntu2.16.04.2" using Xenial/16.04 LTS.

* Ran the testsuite against "3.8.7-2ubuntu2.16.04.2" and no errors were found, apart from a recurrent one which look to me like it did succeed but reported a failure. (false positive).
(It has the exact same report result as previous version "3.8.7-2ubuntu2.16.04.1")

==
Testsuite Full Report
--
# ./test
setfacl failed on this system. ACL tests will not be executed.
./test: line 33: type: selinuxenabled: not found
SELinux disabled. SELinux tests will not be executed.
Running test 1
Running test 2
Running test 3
Running test 4
Running test 5
Running test 6
Skipping SELinux part of test 6
Running test 7
Running test 8
Running test 9
Running test 10
Skipping SELinux part of test 10
Running test 11
Running test 12
Running test 13
Running test 14
Running test 15
Running test 16
Running test 17
Running test 18
Running test 19
Running test 20
Running test 21
Running test 22
Running test 23
Running test 24
Running test 25
Running test 26
Running test 27
Running test 28
Running test 29
Running test 30
Running test 31
Skipping test 32: no ACL support
Skipping test 33: no ACL support
Running test 34
Skipping test 35: no ACL support
Running test 36
Running test 37
Running test 38
Running test 39
Running test 40
Running test 41
Running test 42
Running test 43
Running test 44
Running test 45
Running test 46
Skipping SELinux part of test 6
Running test 47
Skipping SELinux test 47
Running test 48
Skipping test 48: no ACL support
Running test 49
Running test 50
Running test 51
Running test 52
Running test 53
Running test 72
error: destination /tmp/logrotate-3.8.7/test/test.log.1.gz already exists, renaming to /tmp/logrotate-3.8.7/test/test.log.1.gz-2017081520.backup
--

- Eric

We tested this patched package version on ubuntu 14.04, via instructions found https://wiki.ubuntu.com/Testing/EnableProposed.

We tested by manually creating a 2.0 GB file via fallocate under the nginx log directory, and instructing the logrotate nginx config file to rotate any file > 1.0 GB.

This worked, and then I manually corrupted the logrotate status file by
1) removing the top line, creating a new test log file, and verifying logrotate ran.
2) adding a line break in a file other than the top line, creating a new test log file, and verifying logrotate ran.

Patch Behavior appears to be working as designed.

Thank you,
Taylor

The verification of the Stable Release Update for logrotate has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package logrotate - 3.8.7-2ubuntu2.16.04.2

---------------
logrotate (3.8.7-2ubuntu2.16.04.2) xenial; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
    - d/p/do-not-treat-failure-of-readState-as-fatal.patch
    (Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers <email address hidden> Wed, 09 Aug 2017 16:02:21 -0400

This bug was fixed in the package logrotate - 3.8.7-1ubuntu1.2

---------------
logrotate (3.8.7-1ubuntu1.2) trusty; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
    - d/p/do-not-treat-failure-of-readState-as-fatal.patch
    (Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers <email address hidden> Wed, 09 Aug 2017 15:55:36 -0400

### VERIFICATION ZESTY ###

* Couldn't reproduce the above situation using the proposed package version "3.8.7-2ubuntu3.1" using Zesty/17.04.

* Ran the testsuite against "3.8.7-2ubuntu3.1" "/usr/sbin/logrotate" binary and no errors were found, apart from a recurrent one which look to me like it did succeed but reported a failure. (false positive).
(It has the exact same report result as previous version "3.8.7-2ubuntu3")

==
Testsuite Full Report
--
# ./test
setfacl failed on this system. ACL tests will not be executed.
./test: line 33: type: selinuxenabled: not found
SELinux disabled. SELinux tests will not be executed.
Running test 1
Running test 2
Running test 3
Running test 4
Running test 5
Running test 6
Skipping SELinux part of test 6
Running test 7
Running test 8
Running test 9
Running test 10
Skipping SELinux part of test 10
Running test 11
Running test 12
Running test 13
Running test 14
Running test 15
Running test 16
Running test 17
Running test 18
Running test 19
Running test 20
Running test 21
Running test 22
Running test 23
Running test 24
Running test 25
Running test 26
Running test 27
Running test 28
Running test 29
Running test 30
Running test 31
Skipping test 32: no ACL support
Skipping test 33: no ACL support
Running test 34
Skipping test 35: no ACL support
Running test 36
Running test 37
Running test 38
Running test 39
Running test 40
Running test 41
Running test 42
Running test 43
Running test 44
Running test 45
Running test 46
Skipping SELinux part of test 6
Running test 47
Skipping SELinux test 47
Running test 48
Skipping test 48: no ACL support
Running test 49
Running test 50
Running test 51
Running test 52
Running test 53
Running test 72
error: destination /tmp/logrotate-3.8.7/test/test.log.1.gz already exists, renaming to /var/tmp/logrotate-3.8.7/test/test.log.1.gz-2017082114.backup
--

- Eric

This bug was fixed in the package logrotate - 3.8.7-2ubuntu3.1

---------------
logrotate (3.8.7-2ubuntu3.1) zesty; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
    - d/p/do-not-treat-failure-of-readState-as-fatal.patch
    (Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers <email address hidden> Wed, 09 Aug 2017 11:25:51 -0400