cloud-init

'jsonschema' imported but unused

Bug #1695918 reported by Joshua Powers on 2017-06-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	cloud-init	Fix Released	Undecided	Unassigned

Bug Description

From latest build tests:
tests/unittests/test_handler/test_handler_ntp.py:20: 'jsonschema' imported but unused
tests/unittests/test_handler/test_schema.py:16: 'jsonschema' imported but unused

Steps to reproduce:
# git clone master
# cd cloud-init
# tox -e tip-pyflakes

The offending code in both files is:
try:
    import jsonschema # NOQA
    _missing_jsonschema_dep = False
except ImportError:
    _missing_jsonschema_dep = True

Revision history for this message

Joshua Powers (powersj) wrote on 2017-06-07:

The NOQA comment does not appear to work across pyflakes and flake8. A better solution is to assert the import right after to avoid needing to make exceptions for both linters & checkers.

My suggestion:

try:
    import jsonschema
    assert jsonschema
    _missing_jsonschema_dep = False