Ubuntu
budgie-welcome package

[needs packaging] budgie-welcome

Bug #1607546 reported by fossfreedom
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
budgie-welcome (Ubuntu)
Fix Released
Wishlist
fossfreedom

Bug Description

As part of applying for official status for "Ubuntu Budgie", the technical board has requested that the team add our packages to the Ubuntu repos (universe).

"Ubuntu Budgie" will initially consist of eight 17.04 packages - the remaining packages that are not already in the zesty archive are listed here in the PPA description.

 - https://launchpad.net/~budgie-remix/+archive/ubuntu/zesty-proposed

budgie-welcome appears on first logon. It works in a similar manner as Ubuntu Mate Welcome in that it helps the user through what budgie-remix is, first steps, recommendations etc. This is a Ubuntu only package and is not appropriate for wider distribution through Debian

https://launchpad.net/~budgie-remix/+archive/ubuntu/zesty-proposed/+sourcepub/7054026/+listing-archive-extra

See original description
fossfreedom (fossfreedom)
Changed in ubuntu:
status: New → In Progress
assignee: nobody → fossfreedom (fossfreedom)
fossfreedom (fossfreedom)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance: Undecided → Wishlist
Revision history for this message
Daniel Holbach (dholbach) wrote :

It looks like the debian/copyright file isn't quite right: http://paste.ubuntu.com/22681254/

There are also no COPYING or LICENSE files shipped with the budgie-welcome source. Could they be added?

Changed in ubuntu:
status: In Progress → Incomplete
fossfreedom (fossfreedom)
Changed in ubuntu:
status: Incomplete → In Progress
Revision history for this message
fossfreedom (fossfreedom) wrote :

Hi Daniel,

  many thanks for the feedback.

I've taken the opportunity to pull in the latest changes that we are happy with (v0.3.8).

I've added a LICENSE file as requested

Copyright file has been revised.

I've tested both the _source.changes and _all.deb file with lintian -i -I and it returns lintian free.

cheers

David

Revision history for this message
Daniel Holbach (dholbach) wrote :

Why do you use debian/source.lintian-overrides? I'd just list things in there which actually are false positives from lintian.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Apart from that looks good to go from a packaging point of view.

Revision history for this message
fossfreedom (fossfreedom) wrote :

Hi Daniel - correct, they are false positives.

Do you mean somehow comment in "source.lintian-overrides" ?

Is the format for commenting "# this is a comment" ?

Revision history for this message
Daniel Holbach (dholbach) wrote :

budgie-welcome source: source-is-missing data/js/bootstrap.min.js
budgie-welcome source: source-is-missing data/js/tether.js line length is 566 characters (>512)

Both are real issues. Why hide them?

Revision history for this message
fossfreedom (fossfreedom) wrote :

Thanks Daniel,

  those issues have now been resolved and I've uploaded a revised package.

Cheers.

Revision history for this message
fossfreedom (fossfreedom) wrote :

I have uploaded this now to our zesty proposed PPA. Please can this package be considered for inclusion?

description: updated
Revision history for this message
Daniel Holbach (dholbach) wrote :

Uploaded. It should be sitting in the queue of the archive admins to review now.

Changed in ubuntu:
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

I actually can't see it anywhere in the New, Unapproved, or Rejected queues.

Changed in ubuntu:
status: Fix Committed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Ah, it already got accepted, and I typoed the package name: https://launchpad.net/ubuntu/+source/budgie-welcome/0.3.14

affects: ubuntu → budgie-welcome (Ubuntu)
Changed in budgie-welcome (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.