Add the lxqt-abi package and merge from Debian

Bug #1600519 reported by Simon Quigley
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
liblxqt (Ubuntu)
Invalid
Medium
Unassigned

Bug Description

We need to add the lxqt-abi package to ensure LXQt packages don't break in between releases. We also need to merge with the changes made in the Debian package.

Tags: packaging
Simon Quigley (tsimonq2)
Changed in liblxqt (Ubuntu):
assignee: nobody → Simon Quigley (tsimonq2)
status: New → In Progress
summary: - Add the lxqt-abi package
+ Add the lxqt-abi package and merge from Debian
description: updated
Revision history for this message
Simon Quigley (tsimonq2) wrote :

The current fix is in https://git.launchpad.net/~tsimonq2/+git/liblxqt-fix but I've attached the git diff.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Applying this fix requires a no-change rebuild of the following packages:

 - lxqt-about
 - lxqt-panel
 - lxqt-sudo
 - lxqt-session
 - lxqt-runner
 - lxqt-powermanagement
 - lxqt-policykit
 - lxqt-openssh-askpass
 - lxqt-notificationd
 - lxqt-globalkeys
 - lxqt-config
 - lxqt-admin

Revision history for this message
Daniel Holbach (dholbach) wrote :

As mentioned on IRC, please provide a debdiff which applies on top of either the current Debian or the Ubuntu source package.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Daniel, here you go, it's attached.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

The merge from Debian as discussed on IRC would remove the liblxqt-data package, this adds it back.

Revision history for this message
Daniel Holbach (dholbach) wrote :

This would still require a rebuild of all the packages mentioned above, right?

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Correct, Daniel.

Revision history for this message
Julien Lavergne (gilir) wrote :

This merge probably need more discussions. I'll add some background on this:

LXQt upstream handle soname changes very badly in the past (see https://github.com/lxde/lxqt/issues/821). To adapt this, Debian choose to introduce an abi package, a virtual package to work like a soname package.

Personally, I think it's the wrong answer to the problem. IMO, we should patch upstream to set the correct soname name, or adapt the library binary (like a liblxqt0a or liblxqt1 ...). I don't think using a virtual package is a good answer, because Debian library system can handle this natively. Also, if we want to use this solution, we also need to move non .so files out the liblxqt0 binary (for soname transition). That's the reason of the creation of the liblxqt-data binary. Unfortunately, I failed to convince Debian maintainers about this.

However, this is an important divergence with Debian. If we introduce this, we will have to carry this diff probably forever, and I'm also not a fan of adding extra work for this (especially because I'll probably lack time to maintain it properly).

So, for this case, we have 2 choices:
- Diverge from Debian, but the merge needs to be modify to include the changes above, and that will need extra work on Ubuntu side for the future
- Follow Debian, and in this case we can probably sync liblxqt directly from Debian and drop the diff.

I'm fine with both options, if we are all aware of the consequences :-) (I'll also be happy to have an opinion on my change proposal, maybe others ubuntu devs will find it not necessary, so the choice will be easier :-)).

Revision history for this message
Simon Quigley (tsimonq2) wrote :

I would personally choose the second option if you are okay with it, Julien, because it means a lot less work in the long run.

But I lack experience in this situation. Daniel, do you have thoughts?

Revision history for this message
Alf Gaida (agaida) wrote :

With the upcoming release the translations (reason for the data package) will be in *-l10n packages and are built from the new translation repository. So most reasons for a data package are gone. So its up to you - i would suggest to follow debian, its tested, less work and less error prone.

Mathew Hodson (mhodson)
tags: added: packaging
Changed in liblxqt (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Simon Quigley (tsimonq2) wrote :

I now realize that Julien's approach is correct in not wanting the abi package.

Closing this bug, there's nothing else to do.

Changed in liblxqt (Ubuntu):
status: In Progress → Invalid
Simon Quigley (tsimonq2)
Changed in liblxqt (Ubuntu):
assignee: Simon Quigley (tsimonq2) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.