Merge mozc (2.17.2116.102+gitfd0f5b34+dfsg-1) from Debian unstable (main)

Bug #1547816 reported by Ikuya Awashiro
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mozc (Debian)
Fix Released
Unknown
mozc (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Please sync mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) from Debian unstable (main).

mozc (1.15.1857.102-1ubuntu2) is too old.

debian/changelog:

mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) xenial; urgency=medium

  * Merge with Debian, remaining changes:
    - Drop uim support for main inclusion
    - Do not generate shlibs for fcitx
    - Run testcases.
  * debian/patches/enable-test.patch: added for test.

 -- Ikuya Awashiro <email address hidden> Sat, 20 Feb 2016 18:47:42 +0900

mozc (2.17.2116.102+gitfd0f5b34+dfsg-1) unstable; urgency=medium

  * New upstream release.
  * Add support parallel building. (Closes: #795709)
  * Remove libss-dev from Build-Depends. (Closes: #759135)
  * Bump Standards-Version to 3.9.6.

 -- Nobuhiro Iwamatsu <email address hidden> Sat, 12 Sep 2015 13:59:18 +0900

Tags: patch
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :
affects: ibus (Ubuntu) → mozc (Ubuntu)
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "mozc_2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Mathew Hodson (mhodson)
Changed in mozc (Ubuntu):
importance: Undecided → Wishlist
summary: - Sync mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) from Debian unstable
- (main)
+ Merge mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) from Debian
+ unstable (main)
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: Merge mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) from Debian unstable (main)

Thanks, could you explain why that big patch is needed for tests after the update when it was not before? Did upstream drop the testing framework? If so can we report to them that it's useful/used and should be restored?

Revision history for this message
MORISAWA Takayuki (morisawa) wrote :

Debian package maintainer may remove those files to run tests. I don't know for the details.

Revision history for this message
MORISAWA Takayuki (morisawa) wrote :

Please forget my comment.

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Debian package maintainer may remove those files to run tests. I don't know for the details.
(This comment itself is mine)

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Anyway, current Mozc (1.15.1857.102-1ubuntu2) is toooo old.
Newer Mozc has dictionaries with new words. They help a lot.

I wrote an issue [1]. but I got no reply.

[1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815790

What do we do?

1. stay current version. Users are not happy.
2. apply above patch. I know it is hard to accept.
3. drop tests. upstream runs tests at every merge. so I think it is safe.
4. wait for Debian maintainer's answer. Of course we have no time.
5. maintain our own Mozc.

Changed in mozc (Debian):
status: Unknown → New
Revision history for this message
Daniel Holbach (dholbach) wrote :

Can somebody please explain why the patch is necessary? There's no explanation in the patch file itself, nor in debian/changelog.

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Without this patch, it fails to build.

python src/build_mozc.py runtests
INFO: Running: ninja -j 8 -C out_linux/Debug unittests
ninja: Entering directory `out_linux/Debug'
ninja: error: '../../third_party/gmock/src/gmock-cardinalities.cc', needed by 'obj/third_party/gmock/src/testing.gmo
ck-cardinalities.o', missing and no known rule to make it
Traceback (most recent call last):
  File "src/build_mozc.py", line 1454, in <module>
    main()
  File "src/build_mozc.py", line 1450, in main
    procedure[1](cmd_opts, cmd_args, original_directory_name)
  File "src/build_mozc.py", line 1331, in RunTestsMain
    BuildMain(build_opts, build_args, original_directory_name)
  File "src/build_mozc.py", line 1070, in BuildMain
    BuildOnLinux(options, targets, original_directory_name)
  File "src/build_mozc.py", line 1026, in BuildOnLinux
    RunOrDie([make_command] + build_args + target_names)
  File "/home/ikuya/mozc/mozc-2.17.2116.102+gitfd0f5b34+dfsg/src/build_tools/util.py", line 99, in RunOrDie
    '==========']))
build_tools.util.RunOrDieError:
==========
 ERROR: ninja -j 8 -C out_linux/Debug unittests
==========
debian/rules:106: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 1
make[1]: Leaving directory '/home/ikuya/mozc/mozc-2.17.2116.102+gitfd0f5b34+dfsg'
debian/rules:34: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

Hi all,

This is caused by more complex reasons of differencies between two versions of mozc.

* Mozc switched from Google Code/svn to GitHub/git.
* Mozc introduced git-submodules for some packages in src/third_party/ directory.
  * added .gitmodules file
  * NOTE: Mozc in old svn has included all codes for third_party directory.
* mozc package in debian isn't include .gitmodule in upstream branch.
  * its a bug of git-buildpackage or uupdate?
* mozc package in debian dropped binaries in third_party directory for DFSG compliant.
  * from 2.16.2116.102, dfsg flag is added in the version string.
  * therefore, third_party directory became empty and removed.

* src/third_party/{gmock, gtest, jsoncpp} are used only to run test.
  * mozc package in debian doesn't call 'src/build_mozc.py runtests'.
  * mozc package in ubuntu call 'src/build_mozc.py runtests'.
    * it was added by Aron Xu.
* gmock and gtest are depended by allmost tests.
  * i.e. cannot drop 'some' tests which depends gmock/gtest, can only drop 'all' test.
* jsoncpp is used only for network test.
* gtest and jsoncpp is packaged in main and gmock is not packaged.
  * NOTE: Mozc needs source package of jsoncpp, doesn't binary package.
  * gmock was merged to gtest in upstream, but new gtest isn't released yet.

Conclusion:
We should drop runtest as same as Debian.

Is this conclusion acceptable for package in main component?

Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

> We should drop runtest as same as Debian.

Upload debdiff. Please review it.

Anyway, there is no xenail branch for mozc package. Do anyone have any information about this?

https://code.launchpad.net/ubuntu/+source/mozc

summary: - Merge mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) from Debian
- unstable (main)
+ Merge mozc (2.17.2116.102+gitfd0f5b34+dfsg-1) from Debian unstable
+ (main)
Changed in mozc (Ubuntu):
status: New → Confirmed
Revision history for this message
Aron Xu (happyaron) wrote :

Uploaded to queue, let's see if we can get that approved after beta freeze.

Changed in mozc (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Mitsuya Shibata (cosmos-door) wrote : Re: [Bug 1547816] Re: Merge mozc (2.17.2116.102+gitfd0f5b34+dfsg-1) from Debian unstable (main)

Hi Aron

2016-03-24 11:57 GMT+09:00 Aron Xu <email address hidden>:
> Uploaded to queue, let's see if we can get that approved after beta
> freeze.

Thank you for uploading. However after unfreeze, mozc remain in
unapproved queue.
Is there anything what should I do to be approved the package?
--
Mitsuya Shibata
<email address hidden>

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mozc - 2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1

---------------
mozc (2.17.2116.102+gitfd0f5b34+dfsg-1ubuntu1) xenial; urgency=low

  [ Ikuya Awashiro ]
  * Merge from Debian unstable. (LP: #1547816) Remaining changes:
    - Drop uim support for main inclusion
    - Do not generate shlibs for fcitx
    - Add apparmor configuration.

  [ Mitsuya Shibata ]
  * Drop "Run testcases." by new upstream sources changes.
    Upstream drops the code of test frameworks from source archive. We need to
    exec git-submodule to run testcases. Therefore drop "run testcases" as
    same as Debian.

 -- Mitsuya Shibata <email address hidden> Sun, 20 Mar 2016 19:29:14 +0900

Changed in mozc (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Thanks!

Changed in mozc (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.