Alarm description are always "Alarm passed", during first hour of DST change.
Bug #1510694 reported by
Bartosz Kosiorek
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Clock App |
Fix Released
|
High
|
Bartosz Kosiorek | ||
Bug Description
Bug: Alarm description are always "Alarm passed", during first hour of DST change. The root cause of problems, is wrong time calculation, because it is not taking different time zones.
More details is available at video:
https:/
Description of Video
It is an end of DST in Warsaw timezone,
https:/
When DST ends (at 3.00), clocks are set back (as if to repeat one hour) to 2.00
Solution proposal:
We shouldn't assume that two compared Dates are in the same time zone. We should compare Date according to UTC time.
Related branches
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-alarm-description-fix
- Jenkins Bot: Approve (continuous-integration)
- Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration)
- Ubuntu Clock Developers: Pending requested
-
Diff: 198 lines (+55/-23)7 files modifiedapp/alarm/AlarmDelegate.qml (+2/-2)
app/alarm/AlarmUtils.qml (+17/-3)
app/worldclock/WorldCityList.qml (+1/-1)
debian/changelog (+8/-1)
manifest.json.in (+1/-1)
tests/unit/tst_alarm.qml (+6/-3)
tests/unit/tst_alarmUtils.qml (+20/-12)
| Changed in ubuntu-clock-app: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Bartosz Kosiorek (gang65) |
| description: | updated |
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-clock-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-clock-app: | |
| milestone: | none → 3.7 |
Revision history for this message
| Stefan Mikulaj (stefanmikulaj-k) wrote | #2 |
Revision history for this message
| Stefan Mikulaj (stefanmikulaj-k) wrote | #3 |
| Changed in ubuntu-clock-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-clock-app at revision None, scheduled for release in ubuntu-clock-app, milestone 3.7