conflicting deps on pbr breaking pep8 gate jobs

Bug #1456376 reported by Robert Collins
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
hacking
Fix Released
Critical
Joe Gordon

Bug Description

hackings current release is out of sync with global-requirements, *and* due to flake8 triggering pkg_resources checks, this results in a gate failure.

http://logs.openstack.org/52/179952/2/gate/gate-nova-pep8/731ca3d/console.html#_2015-05-18_20_31_11_482

pbr 1.0.0 is installed because its available and compatible with global requirements, but this conflicts with the deps in many oslo projects and thus when flake8 triggers a consistency check, it fails. AIUI we had a similar issue with stevedore at one point.

2015-05-18 20:31:11.265 | /home/jenkins/workspace/gate-nova-pep8$ /home/jenkins/workspace/gate-nova-pep8/.tox/pep8/bin/flake8
2015-05-18 20:31:11.482 | Traceback (most recent call last):
2015-05-18 20:31:11.483 | File ".tox/pep8/bin/flake8", line 9, in <module>
2015-05-18 20:31:11.483 | load_entry_point('flake8==2.2.4', 'console_scripts', 'flake8')()
2015-05-18 20:31:11.483 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/flake8/main.py", line 24, in main
2015-05-18 20:31:11.484 | flake8_style = get_style_guide(parse_argv=True, config_file=DEFAULT_CONFIG)
2015-05-18 20:31:11.484 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/flake8/engine.py", line 105, in get_style_guide
2015-05-18 20:31:11.484 | kwargs['parser'], options_hooks = get_parser()
2015-05-18 20:31:11.485 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/flake8/engine.py", line 55, in get_parser
2015-05-18 20:31:11.485 | (extensions, parser_hooks, options_hooks) = _register_extensions()
2015-05-18 20:31:11.485 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/flake8/engine.py", line 28, in _register_extensions
2015-05-18 20:31:11.485 | checker = entry.load()
2015-05-18 20:31:11.486 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2344, in load
2015-05-18 20:31:11.486 | self.require(*args, **kwargs)
2015-05-18 20:31:11.486 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2361, in require
2015-05-18 20:31:11.487 | items = working_set.resolve(reqs, env, installer)
2015-05-18 20:31:11.487 | File "/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 838, in resolve
2015-05-18 20:31:11.488 | raise VersionConflict(dist, req).with_context(dependent_req)
2015-05-18 20:31:11.489 | pkg_resources.VersionConflict: (pbr 1.0.0 (/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/lib/python2.7/site-packages), Requirement.parse('pbr!=0.7,<1.0,>=0.6'))
2015-05-18 20:31:11.502 | ERROR: InvocationError: '/home/jenkins/workspace/gate-nova-pep8/.tox/pep8/bin/flake8'
2015-05-18 20:31:11.502 | ___________________________________ summary ____________________________________

Revision history for this message
Robert Collins (lifeless) wrote :

Options to fix:
 - get a new flake8 that does whatever stevedore did to avoid this (and update g-r to use it).
 - monkey patch the same sort of thing in via hacking
 - remove pbr 1.0 from g-r to give us breathing room.
 - remove pbr 1.0 from pypi likewise.

summary: - old dep on pbr breaking pep8 gate jobs
+ conflicting deps on pbr breaking pep8 gate jobs
Ian Cordasco (icordasc)
Changed in hacking:
status: New → Confirmed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

The code in stevedore for avoiding checking requirements is a little weird because the setup tools API changed in a way that isn't backwards compatible. See http://git.openstack.org/cgit/openstack/stevedore/tree/stevedore/extension.py#n176

Revision history for this message
Robert Collins (lifeless) wrote :

jogo is cutting a release of hacking 0.10.2 with a compatible pip range; this will get us out of the wedge and we can address all of oslo more calmly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to hacking (0.10.x)

Fix proposed to branch: 0.10.x
Review: https://review.openstack.org/184163

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to hacking (0.10.x)

Reviewed: https://review.openstack.org/184163
Committed: https://git.openstack.org/cgit/openstack-dev/hacking/commit/?id=bc4b1118e155784bc306c01733375ffec56b89b3
Submitter: Jenkins
Branch: 0.10.x

commit bc4b1118e155784bc306c01733375ffec56b89b3
Author: Joe Gordon <email address hidden>
Date: Mon May 18 17:29:02 2015 -0700

    Bump pbr cap to <2.0

    Hacking's pbr cap of <1.0 is breaking things (see bug for a lot more
    detail). Trunk hacking has already moved to the new pbr cap, but it
    there is a backwards incompatible change on trunk
    (I819d2069f169cabd1fcf333057a80790678e3745) that prevents us from
    releasing 0.10.2 from there. So I created a 0.10.x branch and am
    changing the pbr requirement here so that we can cut hacking 0.10.2 to
    fix the bug.

    Change-Id: I77f2b7e661c4de067e39596765d36a4463a2d143
    Closes-Bug: #1456376

Joe Gordon (jogo)
Changed in hacking:
importance: Undecided → Critical
assignee: nobody → Joe Gordon (jogo)
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to hacking (0.9.x)

Fix proposed to branch: 0.9.x
Review: https://review.openstack.org/184224

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to hacking (0.8.x)

Fix proposed to branch: 0.8.x
Review: https://review.openstack.org/184226

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to hacking (0.9.x)

Reviewed: https://review.openstack.org/184224
Committed: https://git.openstack.org/cgit/openstack-dev/hacking/commit/?id=f63394c9a427bdad21bf219135eeb030c2e01145
Submitter: Jenkins
Branch: 0.9.x

commit f63394c9a427bdad21bf219135eeb030c2e01145
Author: Joe Gordon <email address hidden>
Date: Mon May 18 17:29:02 2015 -0700

    Bump pbr cap to <2.0

    Hacking's pbr cap of <1.0 is breaking things (see bug for a lot more
    detail). Since projects are still using hacking 0.9.x bump the PBR cap
    to unbreak projects still on 0.9.x.

    Change-Id: I77f2b7e661c4de067e39596765d36a4463a2d143
    Closes-Bug: #1456376
    (cherry picked from commit bc4b1118e155784bc306c01733375ffec56b89b3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on hacking (0.8.x)

Change abandoned by Joe Gordon (<email address hidden>) on branch: 0.8.x
Review: https://review.openstack.org/184226
Reason: Matt told me to

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.