Switch to the new listitems provided by the SDK
Bug #1426550 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Clock App |
Fix Released
|
Medium
|
Nekhelesh Ramananthan | ||
Bug Description
When the new clock app design was implemented the SDK did not provide support for leading and trailing edge actions in the list items. As a result, we went with custom implementations. Now that Ubuntu Components 1.2 supports leading and trailing actions, let use that and remove all the respective custom code we added.
The following pages include listitems that need to make this transition,
- Alarm Page
- Edit Alarm Page
- Alarm Settings Page
- World Clock Page
- Main Clock Page
Related branches
lp:~ubuntu-clock-dev/ubuntu-clock-app/2-migrate-add-city-listitems
- Bartosz Kosiorek: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 39 lines (+15/-5)1 file modifiedapp/worldclock/WorldCityList.qml (+15/-5)
lp:~ubuntu-clock-dev/ubuntu-clock-app/3-migrate-settings-page-listitems
- Bartosz Kosiorek: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 273 lines (+80/-65)4 files modifiedapp/alarm/AlarmSettingsPage.qml (+49/-29)
app/components/ExpandableListItem.qml (+20/-24)
app/components/SubtitledListItem.qml (+1/-2)
po/com.ubuntu.clock.pot (+10/-10)
lp:~ubuntu-clock-dev/ubuntu-clock-app/4-migrate-alarm-listitems
- Bartosz Kosiorek: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 749 lines (+112/-490)7 files modifiedapp/alarm/AlarmDelegate.qml (+4/-4)
app/alarm/AlarmList.qml (+48/-106)
app/alarm/AlarmPage.qml (+52/-77)
app/components/HeaderButton.qml (+0/-65)
app/upstreamcomponents/MultipleSelectionListView.qml (+0/-199)
app/upstreamcomponents/MultipleSelectionVisualModel.qml (+0/-31)
po/com.ubuntu.clock.pot (+8/-8)
lp:~ubuntu-clock-dev/ubuntu-clock-app/5-finish-alarm-migration
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Bartosz Kosiorek: Approve
-
Diff: 130 lines (+16/-11)5 files modifiedapp/alarm/AlarmRepeat.qml (+4/-4)
app/alarm/AlarmSound.qml (+8/-3)
app/alarm/EditAlarmPage.qml (+0/-1)
debian/changelog (+1/-0)
po/com.ubuntu.clock.pot (+3/-3)
| Changed in ubuntu-clock-app: | |
| milestone: | devel → none |
| assignee: | Nekhelesh Ramananthan (nik90) → nobody |
| no longer affects: | ubuntu-clock-app/utopic-14.10 |
| Changed in ubuntu-clock-app: | |
| status: | Triaged → Won't Fix |
| importance: | Medium → Undecided |
| Changed in ubuntu-clock-app: | |
| milestone: | none → 3.4 |
| assignee: | nobody → Nekhelesh Ramananthan (nik90) |
| importance: | Undecided → Medium |
| status: | Won't Fix → In Progress |
| no longer affects: | ubuntu-clock-app/vivid-15.04 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in ubuntu-clock-app: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #3 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #4 |
| Changed in ubuntu-clock-app: | |
| milestone: | 3.4 → 3.5 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #5 |
| Changed in ubuntu-clock-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This cannot be fixed in Utopic-14.10 (RTM) since the new listitems is available in the SDK version shipped with RTM.