Calculator gets increasingly slower with long calculations

Bug #1333201 reported by Alan Pope ๐Ÿบ๐Ÿง๐Ÿฑ ๐Ÿฆ„
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Calculator App
Fix Released
High
Bartosz Kosiorek

Bug Description

Open calculator
Type 1+1=
Then press = repeatedly
The calculator gets slower with each iteration.

Reported by tvoss on irc, and confirmed by me.

12:01:36 < tvoss> popey, seems like it is not storing intermediate results but instead walks the stack each and every single time

Duplicate of the:
https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1315799

Tags: bitesize

Related branches

Changed in ubuntu-calculator-app:
status: New → Confirmed
importance: Undecided → Medium
tags: added: bitesize
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

The root cause of problem was that whole formula is calculated every time.
This bug is duplicate of the:
https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1315799

Changed in ubuntu-calculator-app:
status: Confirmed → Triaged
description: updated
Revision history for this message
Victor Tuson Palau (vtuson) wrote :

this makes the app unusable, how can it be medium?

Changed in ubuntu-calculator-app:
importance: Medium → High
Changed in ubuntu-calculator-app:
status: Triaged → In Progress
assignee: nobody → Riccardo Padovani (rpadovani)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-calculator-app at revision 289, scheduled for release in ubuntu-calculator-app, milestone 1.6

Changed in ubuntu-calculator-app:
status: In Progress → Fix Committed
Revision history for this message
xreuze (xreuze) wrote : Re: [Bug 1333201] Re: Calculator gets increasingly slower with long calculations

I con make it , 4 000 forest to

On Tue, Jul 8, 2014 at 5:31 PM, PS Jenkins bot <
<email address hidden>> wrote:

> Fix committed into lp:ubuntu-calculator-app at revision 289, scheduled
> for release in ubuntu-calculator-app, milestone 1.6
>
> ** Changed in: ubuntu-calculator-app
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to Ubuntu
> Touch Core Apps.
> Matching subscriptions: Touch Core Apps Bugs, Unity 8
> https://bugs.launchpad.net/bugs/1333201
>
> Title:
> Calculator gets increasingly slower with long calculations
>
> Status in Calculator application for Ubuntu devices:
> Fix Committed
>
> Bug description:
> Open calculator
> Type 1+1=
> Then press = repeatedly
> The calculator gets slower with each iteration.
>
> Reported by tvoss on irc, and confirmed by me.
>
> 12:01:36 < tvoss> popey, seems like it is not storing intermediate
> results but instead walks the stack each and every single time
>
> Duplicate of the:
> https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1315799
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1333201/+subscriptions
>

Revision history for this message
xreuze (xreuze) wrote :

I know.. kiss pusss

On Tue, Jul 8, 2014 at 7:00 PM, Bob Looter <email address hidden> wrote:

> I con make it , 4 000 forest to
>
>
> On Tue, Jul 8, 2014 at 5:31 PM, PS Jenkins bot <
> <email address hidden>> wrote:
>
>> Fix committed into lp:ubuntu-calculator-app at revision 289, scheduled
>> for release in ubuntu-calculator-app, milestone 1.6
>>
>> ** Changed in: ubuntu-calculator-app
>> Status: In Progress => Fix Committed
>>
>> --
>> You received this bug notification because you are subscribed to Ubuntu
>> Touch Core Apps.
>> Matching subscriptions: Touch Core Apps Bugs, Unity 8
>> https://bugs.launchpad.net/bugs/1333201
>>
>> Title:
>> Calculator gets increasingly slower with long calculations
>>
>> Status in Calculator application for Ubuntu devices:
>> Fix Committed
>>
>> Bug description:
>> Open calculator
>> Type 1+1=
>> Then press = repeatedly
>> The calculator gets slower with each iteration.
>>
>> Reported by tvoss on irc, and confirmed by me.
>>
>> 12:01:36 < tvoss> popey, seems like it is not storing intermediate
>> results but instead walks the stack each and every single time
>>
>> Duplicate of the:
>> https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1315799
>>
>> To manage notifications about this bug go to:
>>
>> https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1333201/+subscriptions
>>
>
>

Changed in ubuntu-calculator-app:
assignee: Riccardo Padovani (rpadovani) → Bartosz Kosiorek (gang65)
status: Fix Committed → In Progress
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Thanks Riccardo for your hard work.
Unfortunately slowdown still exists (please try to press "=" repeatedly).

I already fixed slowdown (see branch), but there are also several regressions:
1. Unable to change sign of the result
2. The error: file:///home/a/dev/core/ubuntu-calculator-app/engine.js:359: Too long number is displayed with a long number
3. Backspace is not working correclty (it doesn't delete last char)
4. Scanner is not working correctly for single number (formula.js)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-calculator-app at revision 324, scheduled for release in ubuntu-calculator-app, milestone 1.6

Changed in ubuntu-calculator-app:
status: In Progress → Fix Committed
Changed in ubuntu-calculator-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.