UniterAPI.GetOwnerTag needs doc comment and permissions checks

Bug #1270795 reported by Dimiter Naydenov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Low
Dimiter Naydenov

Bug Description

UniterAPI's GetOwnerTag which landed with https://codereview.appspot.com/14389043/ needs a doc comment and permission checks, using u.accessService(), like the other methods that operate on a service.

Tags: tech-debt
Martin Packman (gz)
Changed in juju-core:
milestone: 1.17.1 → 1.18.0
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: 1.18.0 → none
Changed in juju-core:
status: Triaged → In Progress
assignee: nobody → Dimiter Naydenov (dimitern)
milestone: none → next-stable
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: next-stable → none
Changed in juju-core:
status: In Progress → Fix Committed
milestone: none → 1.21-alpha2
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

As the Uniter API is now versioned, GetOwnerTag is still in V0, but in V1 it was replaced by ServiceOwner, which does proper bulk ops handling and permission checks, so I consider this closed.

Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.