Please remove qtmultimedia private headers usage to work with Qt 5.2

https://code.launchpad.net/~aacid/qtubuntu-camera/no_priv_headers fixes the qtubuntu-camera one

I'll take a look at this to see if it's required for qtvideo-node with my work on media-hub. I'll also take a look at this for qtubuntu-media.

https://code.launchpad.net/~aacid/qtubuntu-cameraplugin-fake/no_need_for_multimedia_private/+merge/202688 fixes the qtubuntu-cameraplugin-fake side

https://code.launchpad.net/~aacid/qtubuntu-media/noprivate/+merge/202708 for qtubuntu-media

qtvideo-node seems to depend on at least qsgvideonode_p.h which is a private header and not available anymore.

qsgvideonode_p.h is still there and is installed as private header by qtmultimedia as you can see in https://qt.gitorious.org/qt/qtmultimedia/source/819f30df336ec58ec487f19919ade198d016826d:src/qtmultimediaquicktools/qtmultimediaquicktools.pro

Yes, it's in the sources but the private headers were dropped from the packaging. So it's "not there" in the Debian + Ubuntu packaging anymore, so it's wished for we wouldn't need to differentiate from Debian packaging by looking into whether it could be workarounded.

Jim (or Ricardo), any update on qtvideo-node?

I'm not exactly sure what to do about qtvideo-node, because a class directly inherits from QSGVideoNode which is contained in qsgvideonode_p.h. I haven't been able to locate an alternate header file to include that provides for this class. A search for that class reveals 0 results on Qt's documentation search. Any suggestions?

If we totally need that class and we totally can't use qtmultimedia private headers (which is a weird restriction since e.g. we're using qtdeclarative private headers a lot) I guess your only solution would be convincing Qt upstream to make that class public explaining our usecase. But I guess they'll suggest you use the private header :D

Of course the evil solution is just copying the private header over to qtvideo-node sources, but i would never suggest that :D

Ha, I should have refreshed this page earlier, since I just sent an e-mail mentioning this bug :)

I think it's worth filing a bug upstream (https://bugreports.qt-project.org/) to ask whether the class could be made public? I mean, if there's an use case they don't consider evil that should be allowed with public headers.

We can stay forking qtmultimedia packaging as well, but it's just not the preferred option. I guess it'd be however less ugly than copying the private header.

As we're already maintaining qtvideo-node, I'd just vote to copy it over so you can sync the package without changes from Debian (but also check with upstream what can be done in the right way).

I tried hacking something quickly, and pushed a branch to under lp:~phablet-team/qtvideo-node/support_qt52 where it can be co-worked. Could someone who knows a bit more what he's doing than me look at it and see if it could be finished? :)

I copied qsgvideonode_p.h and qtmultimediaquickdefs_p.h to the sources for build to succeed with only qtdeclarative5-private-dev and qtmultimedia5-dev. I additionally noticed that QSGMaterial had moved to under a subdirectory in Qt 5.2 so there needed to be #ifdef for that.

It built fine against Qt 5.2:
https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+sourcepub/3883608/+listing-archive-extra

Unit tests were disabled since there's a linker error. But at least this gives the PPA the package so that cameraplugin-aal and qtvideo-node itself do not need to be removed when upgrading.

Thanks Timo, I'll test this out for you soon and let you know if it works ok. Thanks for helping move qtvideo-node along.

Is this resolved?

No. The qtvideo-node still has only the hacked + tests disabled manual upload in the archives, while Jim promised to work on this. Since camera depends on qtvideo-node, I believe this bug is why the camera shuts down on startup bug #1277160.

Fix is committed and approved, just waiting for merge approval.

This bug was fixed in the package qtvideo-node - 0.2.1+14.04.20140304-0ubuntu1

---------------
qtvideo-node (0.2.1+14.04.20140304-0ubuntu1) trusty; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Ricardo Salveti de Araujo ]
  * Initial Qt 5.2 support. Copy two header files from qtmultimedia
    private headers. Only use Qt Declarative private headers (quick-
    private) otherwise, and use version detection to support both 5.0
    and 5.2. Disable unit tests temporarily. (LP: #1267818)

  [ Timo Jyrinki ]
  * Initial Qt 5.2 support. Copy two header files from qtmultimedia
    private headers. Only use Qt Declarative private headers (quick-
    private) otherwise, and use version detection to support both 5.0
    and 5.2. Disable unit tests temporarily. (LP: #1267818)
 -- Ubuntu daily release <email address hidden> Tue, 04 Mar 2014 13:44:19 +0000