juju-core

environment-tag handling permits non-unique tags

Bug #1257587 reported by Andrew Wilkins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Low
Unassigned
juju-core 1.21-alpha1

Bug Description

Juju currently uses the environment name (user specifiable, likely to be non-unique) to identify an environment in an environment tag. We would like to change this to be a UUID.

There is currently only one user (Landscape) of environment tags, and they are going to change to using UUIDs with a temporary backwards-compatibility change to continue working with older releases of Juju.

We will continue to accept environment-$name as well as environment-$uuid (in fact we'll just accept environment-*); in a future release we should only accept a UUID matching the current environment's.

Curtis Hovey (sinzui)
Changed in juju-core:
importance: Medium → Low
Domas Monkus (tasdomas)
Changed in juju-core:
status: Triaged → Fix Released
Revision history for this message
Andrew Wilkins (axwalk) wrote :

Please mark Fix Committed when dependencies.tsv is updated in Juju, and Fix Released when it's released to the public. Closing bugs prematurely bites us when changes get left in limbo.

Also, have you confirmed that Landscape have actually changed their code to allows us to do this?

Changed in juju-core:
status: Fix Released → In Progress
Domas Monkus (tasdomas)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: none → 1.21-alpha1
Revision history for this message
Tim Penhey (thumper) wrote :

How can this bug be fix committed? We currently completely ignore the tag being passed in and just write out a warning.

Surely this bug isn't fixed until we reject access through environment tags that don't use a UUID?

I was about to make a branch that caused names.NewEnvironTag to panic if the uuid wasn't a valid environ tag (matching uuid regex), but since this looks like a 1.21 change, we should wait a release.

Revision history for this message
Andrew Wilkins (axwalk) wrote :

@thumper This bug was specifically about *existing* environment tag validation, not about requiring it across the board.

Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.