Sync csound 1:6.00.1~dfsg-2 (universe) from Debian unstable (main)

Bug #1240227 reported by Felipe Sateler
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
csound (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Please sync csound 1:6.00.1~dfsg-2 (universe) from Debian unstable (main)

Explanation of the Ubuntu delta and why it can be dropped:
  * Added missing pthread lib to link, fixing FTBFS.
  * Added missing pthread lib to link, fixing FTBFS.

I assume the missing pthread issue (no link in either changelog or patch)
relates to the same bug reported in debian as #713667, which was fixed
in 1:6.00~dfsg-1.

Changelog entries since current saucy version 1:5.17.11~dfsg-3ubuntu1:

csound (1:6.00.1~dfsg-2) unstable; urgency=low

  * Enable lua opcodes
    - Use lua instead of luajit
  * Get several patches from upstream git.
    - Only enable atomic builtins in amd64 and i386. Fixes FTBFS in some archs
    - Fix FTBFS on big endian archs

 -- Felipe Sateler <email address hidden> Sun, 01 Sep 2013 23:41:52 -0400

csound (1:6.00.1~dfsg-1) unstable; urgency=low

  * New upstream release
   - Remove patch applied upstream
   - Remove patch to refman_header, no longer in source
   - Refresh patches
  * Backport several cmake fixes
  * Disable default optimizations. Closes: #718969

 -- Felipe Sateler <email address hidden> Wed, 14 Aug 2013 19:04:18 -0400

csound (1:6.00~dfsg-1) unstable; urgency=low

  * New upstream release
   - Rename packages for csound 6, ABI break
   - Enable multicore, is now required
   - Disable the p5 glove opcodes
   - Refresh patches, drop patch 1000, applied upstream
   - Update copyright file
   - Add patch from upstream hiding some unwanted symbols
   - Fix crash in sdif2ad. Closes: #716233
  * Do not build tests yet
  * Drop tclcsound, upstream no longer builds it
  * Install new csanalyze and scope tools
  * python module is now csnd6
  * Drop SO versioning of lua interfaces, they are not versioned
  * Fixes FTBFS: Closes: #713667
  *

 -- Felipe Sateler <email address hidden> Sat, 03 Aug 2013 18:47:12 -0400

csound (1:5.17.11~dfsg-4) unstable; urgency=low

  * Team upload.

  [ Jonas Smedegaard ]
  * Update README.source to emphasize control.in file as *not* a
    show-stopper for contributions, referring to wiki page for details.

  [ Sebastian Ramacher ]
  * debian/patches/2015-bison-2.6.patch: Apply patch from upstream to fix
    compilation with bison 2.6. (Closes: #710619)
  * debian/{control,rules}: Bump bison to (>= 2.6) to be on the safe side.
  * debian/control{,.in}: Change section of libcsoundac5.2 and libcsnd5.2 to
    libs.

 -- Sebastian Ramacher <email address hidden> Wed, 05 Jun 2013 01:18:00 +0200

Revision history for this message
Daniel Holbach (dholbach) wrote :

This unfortunately fails to build on trusty amd64:

[ 2%] Building C object CMakeFiles/csound64.dir/Engine/envvar.c.o
/usr/bin/x86_64-linux-gnu-gcc -DCS_DEFAULT_PLUGINDIR=\"/usr/lib/csound/plugins64-6.0\" -DHAVE_STRTOD_L -DHAVE_STRTOK_R -DLINUX -DPIPES -DUSE_DOUBLE -DUSE_LRINT -D_CSOUND_RELEASE_ -D_GNU_SOURCE -Dcsound64_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -D_FORTIFY_SOURCE=2 -DHAVE_ATOMIC_BUILTIN -fPIC -I"/tmp/buildd/csound-6.00.1~dfsg/./H" -I"/tmp/buildd/csound-6.00.1~dfsg/./include" -I"/tmp/buildd/csound-6.00.1~dfsg/./Engine" -I"/tmp/buildd/csound-6.00.1~dfsg/." -I"/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu" -ftree-vectorize -ffast-math -O3 -mtune=generic -fvisibility=hidden -Wno-format -D__BUILDING_LIBCSOUND -DHAVE_PTHREAD_SPIN_LOCK -DHAVE_PTHREAD_BARRIER_INIT -DPARCS -DGNU_GETTEXT -DHAVE_DIRENT_H -DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H -DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -o CMakeFiles/csound64.dir/Engine/envvar.c.o -c "/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c"
/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundParseEnv':
/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:383:7: error: format not a string literal and no format arguments [-Werror=format-security]
       csoundMessage(csound, Str(msg));
       ^
/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundGetDirectoryForPath':
/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:720:7: error: format not a string literal and no format arguments [-Werror=format-security]
       csoundDie(csound, Str("Current directory path name too long\n"));
       ^
cc1: some warnings being treated as errors
make[3]: *** [CMakeFiles/csound64.dir/Engine/envvar.c.o] Error 1
make[3]: Leaving directory `/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/csound64.dir/all] Error 2

Changed in csound (Ubuntu):
status: New → Incomplete
Revision history for this message
Felipe Sateler (fsateler) wrote : Re: [Bug 1240227] Re: Sync csound 1:6.00.1~dfsg-2 (universe) from Debian unstable (main)

On Mon, Oct 21, 2013 at 6:23 AM, Daniel Holbach
<email address hidden> wrote:
> This unfortunately fails to build on trusty amd64:
>
> [ 2%] Building C object CMakeFiles/csound64.dir/Engine/envvar.c.o
> /usr/bin/x86_64-linux-gnu-gcc -DCS_DEFAULT_PLUGINDIR=\"/usr/lib/csound/plugins64-6.0\" -DHAVE_STRTOD_L -DHAVE_STRTOK_R -DLINUX -DPIPES -DUSE_DOUBLE -DUSE_LRINT -D_CSOUND_RELEASE_ -D_GNU_SOURCE -Dcsound64_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -D_FORTIFY_SOURCE=2 -DHAVE_ATOMIC_BUILTIN -fPIC -I"/tmp/buildd/csound-6.00.1~dfsg/./H" -I"/tmp/buildd/csound-6.00.1~dfsg/./include" -I"/tmp/buildd/csound-6.00.1~dfsg/./Engine" -I"/tmp/buildd/csound-6.00.1~dfsg/." -I"/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu" -ftree-vectorize -ffast-math -O3 -mtune=generic -fvisibility=hidden -Wno-format -D__BUILDING_LIBCSOUND -DHAVE_PTHREAD_SPIN_LOCK -DHAVE_PTHREAD_BARRIER_INIT -DPARCS -DGNU_GETTEXT -DHAVE_DIRENT_H -DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H -DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -o CMakeFiles/csound64.dir/Engine/envvar.c.o -c "/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c"
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundParseEnv':
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:383:7: error: format not a string literal and no format arguments [-Werror=format-security]
> csoundMessage(csound, Str(msg));
> ^
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundGetDirectoryForPath':
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:720:7: error: format not a string literal and no format arguments [-Werror=format-security]
> csoundDie(csound, Str("Current directory path name too long\n"));
> ^

Hmm. Str is the csound name for gettext. Is it possible to disable
this -Werror? Or do I need to patch the source to pass "%s" as the
first string everywhere?

--

Saludos,
Felipe Sateler

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

That error is coming not from Str, but rather from csoundDie/csoundMessage.

If message contains percent chars, random parts of the stack can be printed, so yes, you need to pass "%s" everywhere.

Revision history for this message
Felipe Sateler (fsateler) wrote :

On Thu, Oct 24, 2013 at 5:12 AM, Dmitry Shachnev <email address hidden> wrote:
> That error is coming not from Str, but rather from
> csoundDie/csoundMessage.

I know.

> If message contains percent chars, random parts of the stack can be
> printed, so yes, you need to pass "%s" everywhere.

They can't have percent chars, because they do not come from user
input. They are all constant strings passed through gettext.

Really, this warning is too trigger happy.

--

Saludos,
Felipe Sateler

Revision history for this message
Sebastien Bacher (seb128) wrote :

Unsubscribing sponsors, we can't sync something that doesn't build. Can you fix the build issue (in Debian if possible) then subscribe sponsors back?

Revision history for this message
Felipe Sateler (fsateler) wrote :

On Thu, Nov 7, 2013 at 9:58 AM, Sebastien Bacher <email address hidden> wrote:
> Unsubscribing sponsors, we can't sync something that doesn't build. Can
> you fix the build issue (in Debian if possible) then subscribe sponsors
> back?

I don't know how to do that. But please sync the latest version from
unstable (1:6.01~dfsg-2), it builds in trusty now.

--

Saludos,
Felipe Sateler

Revision history for this message
Felipe Sateler (fsateler) wrote :

On Mon, Oct 21, 2013 at 6:23 AM, Daniel Holbach
<email address hidden> wrote:
> This unfortunately fails to build on trusty amd64:
>
> [ 2%] Building C object CMakeFiles/csound64.dir/Engine/envvar.c.o
> /usr/bin/x86_64-linux-gnu-gcc -DCS_DEFAULT_PLUGINDIR=\"/usr/lib/csound/plugins64-6.0\" -DHAVE_STRTOD_L -DHAVE_STRTOK_R -DLINUX -DPIPES -DUSE_DOUBLE -DUSE_LRINT -D_CSOUND_RELEASE_ -D_GNU_SOURCE -Dcsound64_EXPORTS -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -D_FORTIFY_SOURCE=2 -DHAVE_ATOMIC_BUILTIN -fPIC -I"/tmp/buildd/csound-6.00.1~dfsg/./H" -I"/tmp/buildd/csound-6.00.1~dfsg/./include" -I"/tmp/buildd/csound-6.00.1~dfsg/./Engine" -I"/tmp/buildd/csound-6.00.1~dfsg/." -I"/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu" -ftree-vectorize -ffast-math -O3 -mtune=generic -fvisibility=hidden -Wno-format -D__BUILDING_LIBCSOUND -DHAVE_PTHREAD_SPIN_LOCK -DHAVE_PTHREAD_BARRIER_INIT -DPARCS -DGNU_GETTEXT -DHAVE_DIRENT_H -DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H -DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -o CMakeFiles/csound64.dir/Engine/envvar.c.o -c "/tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c"
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundParseEnv':
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:383:7: error: format not a string literal and no format arguments [-Werror=format-security]
> csoundMessage(csound, Str(msg));
> ^
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c: In function 'csoundGetDirectoryForPath':
> /tmp/buildd/csound-6.00.1~dfsg/Engine/envvar.c:720:7: error: format not a string literal and no format arguments [-Werror=format-security]
> csoundDie(csound, Str("Current directory path name too long\n"));
> ^
> cc1: some warnings being treated as errors
> make[3]: *** [CMakeFiles/csound64.dir/Engine/envvar.c.o] Error 1
> make[3]: Leaving directory `/tmp/buildd/csound-6.00.1~dfsg/obj-x86_64-linux-gnu'
> make[2]: *** [CMakeFiles/csound64.dir/all] Error 2
>

FIxed in the latest version from unstable (1:6.01~dfsg-2). Please sync
that version.

Thanks

--

Saludos,
Felipe Sateler

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

This bug was fixed in the package csound - 1:6.01~dfsg-2
Sponsored for Felipe Sateler (fsateler)

---------------
csound (1:6.01~dfsg-2) unstable; urgency=low

  * Upload to unstable
  * Fix csoundac description
  * link to packaged jquery in doc
  * Build documentation in the build-indep target
  * Backport fix to the java interface from upstream
  * Improve clean rule
  * No error on format security. Avoids FTBFS in Ubuntu

 -- Felipe Sateler <email address hidden> Tue, 19 Nov 2013 00:01:30 -0300

csound (1:6.01~dfsg-1) experimental; urgency=low

  * New upstream version
    - Drop patches applied upstream
    - Refresh patches
    - Do not build max opcode
    - Add max msp frontend copyright
    - Update copyright hints
    - Update symbols file
    - csoundapi~ -> csound6~
    - libcsnd library renamed to libcsnd6
  * Remove csound-gui package
    - There are no frontends anymore, the split makes no sense
  * Enable openmp
  * Use system portsmf
  * Ensure doc build dir exists
  * Regenerate debian/control

 -- Felipe Sateler <email address hidden> Sat, 19 Oct 2013 19:40:55 -0300

csound (1:6.00.1~dfsg-2) unstable; urgency=low

  * Enable lua opcodes
    - Use lua instead of luajit
  * Get several patches from upstream git.
    - Only enable atomic builtins in amd64 and i386. Fixes FTBFS in some archs
    - Fix FTBFS on big endian archs

 -- Felipe Sateler <email address hidden> Sun, 01 Sep 2013 23:41:52 -0400

csound (1:6.00.1~dfsg-1) unstable; urgency=low

  * New upstream release
   - Remove patch applied upstream
   - Remove patch to refman_header, no longer in source
   - Refresh patches
  * Backport several cmake fixes
  * Disable default optimizations. Closes: #718969

 -- Felipe Sateler <email address hidden> Wed, 14 Aug 2013 19:04:18 -0400

csound (1:6.00~dfsg-1) unstable; urgency=low

  * New upstream release
   - Rename packages for csound 6, ABI break
   - Enable multicore, is now required
   - Disable the p5 glove opcodes
   - Refresh patches, drop patch 1000, applied upstream
   - Update copyright file
   - Add patch from upstream hiding some unwanted symbols
   - Fix crash in sdif2ad. Closes: #716233
  * Do not build tests yet
  * Drop tclcsound, upstream no longer builds it
  * Install new csanalyze and scope tools
  * python module is now csnd6
  * Drop SO versioning of lua interfaces, they are not versioned
  * Fixes FTBFS: Closes: #713667
  *

 -- Felipe Sateler <email address hidden> Sat, 03 Aug 2013 18:47:12 -0400

csound (1:5.17.11~dfsg-4) unstable; urgency=low

  * Team upload.

  [ Jonas Smedegaard ]
  * Update README.source to emphasize control.in file as *not* a
    show-stopper for contributions, referring to wiki page for details.

  [ Sebastian Ramacher ]
  * debian/patches/2015-bison-2.6.patch: Apply patch from upstream to fix
    compilation with bison 2.6. (Closes: #710619)
  * debian/{control,rules}: Bump bison to (>= 2.6) to be on the safe side.
  * debian/control{,.in}: Change section of libcsoundac5.2 and libcsnd5.2 to
    libs.

 -- Sebastian Ramacher <email address hidden> Wed, 05 Jun 2013 01:18:00 +0200

Changed in csound (Ubuntu):
status: Incomplete → Fix Released
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Hi Felipe,

Apparently csound failed to migrate to -release because csound-qt FTBFS against the new version. The error is "/usr/bin/ld: cannot find -lcsnd", check build logs at https://launchpad.net/ubuntu/+source/csoundqt/0.8.0-2.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Also, is csound-gui really removed? csound still recommends it, and I see it in http://packages.debian.org/sid/csound-gui. Either changelog or control should be fixed :)

Revision history for this message
Felipe Sateler (fsateler) wrote :

On Fri, Nov 22, 2013 at 7:55 AM, Dmitry Shachnev <email address hidden> wrote:
> Hi Felipe,
>
> Apparently csound failed to migrate to -release because csound-qt FTBFS
> against the new version. The error is "/usr/bin/ld: cannot find -lcsnd",
> check build logs at
> https://launchpad.net/ubuntu/+source/csoundqt/0.8.0-2.

Oops, my bad. Uploaded 0.8.0-3 fixing the issue. Thanks for reporting!

On Fri, Nov 22, 2013 at 8:26 AM, Dmitry Shachnev <email address hidden> wrote:
> Also, is csound-gui really removed? csound still recommends it, and I
> see it in http://packages.debian.org/sid/csound-gui. Either changelog or
> control should be fixed :)

The control file is incorrect. I've commited a fix locally, but not
sure a stale recommends is worth a new upload.

--

Saludos,
Felipe Sateler

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.